feat: validate pycross package override labels - #298
Conversation
dcee8a3 to
f0bba0c
Compare
|
Hey Greg, nice to hear from you. Just to make sure we're on the same page, |
|
We're on v1 and this was one patch we can ditch before upgrade to v2. I probably should have looked at the v2 code first! 🤣 What's the nearest equivalent? Or is there no such thing in v2? Is the intent clear of what we're looking for? |
|
There's still lock importing in v2, but it looks more like: (sub And there's still a I think that's the largest conflict with this patch; it seems like it would work, but would require users to use that hidden workspace repo to access it, fighting with |
Context
At $dayjob we carry a
rules_pycrosspatch that ensures we don't have stalelock_importinrules_pycross.MODULE.bazel. In this PR we are seeking to upstream this patch if it is useful or interesting to the maintainers.It does this by generating a test that approximately looks like this:
This enables the optional addition of a
build_testto ensure that there are no stale `lock_imports.